Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/260#discussion_r45006882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkAbstractStore.java
---
@@ -23,30 +23,35 @@
import java.util.Iterator;
import java.util.List;
import java.util.Map.Entry;
+import java.util.concurrent.TimeUnit;
import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.api.ACLBackgroundPathAndBytesable;
import org.apache.curator.framework.recipes.cache.ChildData;
import org.apache.curator.framework.recipes.cache.PathChildrenCache;
import
org.apache.curator.framework.recipes.cache.PathChildrenCache.StartMode;
-import org.apache.drill.exec.rpc.data.DataTunnel;
+import org.apache.curator.framework.recipes.locks.InterProcessLock;
import org.apache.drill.exec.store.sys.PStoreConfig;
import org.apache.zookeeper.CreateMode;
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
+import org.apache.zookeeper.KeeperException;
/**
* This is the abstract class that is shared by ZkPStore (Persistent
store) and ZkEStore (Ephemeral Store)
* @param <V>
*/
public abstract class ZkAbstractStore<V> implements AutoCloseable {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ZkAbstractStore.class);
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ZkAbstractStore.class);
- protected CuratorFramework framework;
- protected PStoreConfig<V> config;
+ protected static final long LOCK_TIMEOUT_MILLIS = 3000;
--- End diff --
unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
