Sounds good. -- Jacques Nadeau CTO and Co-Founder, Dremio
On Wed, Dec 2, 2015 at 2:47 PM, Steven Phillips <[email protected]> wrote: > Okay, I'm going to go ahead and merge DRILL-4145 > > On Wed, Dec 2, 2015 at 2:45 PM, Venki Korukanti <[email protected] > > > wrote: > > > For DRILL-4145: ran the regression suite which includes customer and > > extended tests. No regressions found. > > > > On Wed, Dec 2, 2015 at 1:41 PM, Venki Korukanti < > [email protected] > > > > > wrote: > > > > > Sure, I will trigger a regression run with DRILL-4145. > > > > > > Thanks > > > Venki > > > > > > On Wed, Dec 2, 2015 at 1:36 PM, Jacques Nadeau <[email protected]> > > wrote: > > > > > >> I believe 4109 is ready but if I understand correctly, it can't go in > > >> without 4125. Amit said he needs another hour for that. > > >> > > >> On 4145: Venki, can someone on your side running any extended/customer > > >> tests you have against this to make sure that it doesn't cause any > > >> regressions. We've run on our side without issue but I'd like to get > as > > >> broad of coverage as possible to ensure no issues. > > >> > > >> -- > > >> Jacques Nadeau > > >> CTO and Co-Founder, Dremio > > >> > > >> On Wed, Dec 2, 2015 at 11:52 AM, Venki Korukanti < > > >> [email protected]> > > >> wrote: > > >> > > >> > Sure, we can include DRILL-4124. I will merge it soon. Any idea when > > the > > >> > following JIRAs are going to be ready to commit? > > >> > > > >> > DRILL-4109 (in review) > > >> > DRILL-4125 > > >> > DRILL-4145 (in review) > > >> > > > >> > Jinfeng and I discussed about including metastore caching and > decided > > to > > >> > move it to 1.5. > > >> > > > >> > Lets make 5pm as the cutoff time for 1.4 branch. > > >> > > > >> > Thanks > > >> > Venki > > >> > > > >> > On Wed, Dec 2, 2015 at 11:42 AM, Julien Le Dem <[email protected]> > > >> wrote: > > >> > > > >> > > DRILL-4124 is ready to merge: > > >> https://github.com/apache/drill/pull/281 > > >> > > It is a small change. > > >> > > > > >> > > On Wed, Dec 2, 2015 at 7:58 AM, Venki Korukanti < > > >> > [email protected] > > >> > > > > > >> > > wrote: > > >> > > > > >> > > > I posted a comment on the commit DRILL-4126 (for some reason no > > >> emails > > >> > > are > > >> > > > sent to dev list, may be because of the multiple commits in the > > pull > > >> > > > request). > > >> > > > > > >> > > > On Wed, Dec 2, 2015 at 7:53 AM, Jinfeng Ni < > [email protected] > > > > > >> > > wrote: > > >> > > > > > >> > > > > If the window is still open, I would like to have DRILL-4126, > > >> > > > > DRILL-4127 merged as well. > > >> > > > > > > >> > > > > Venki, could you please review the revised patch? > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > On Wed, Dec 2, 2015 at 7:49 AM, Venki Korukanti > > >> > > > > <[email protected]> wrote: > > >> > > > > > Remaining JIRAs: > > >> > > > > > > > >> > > > > > DRILL-4109 (in review) > > >> > > > > > DRILL-4125 > > >> > > > > > DRILL-4145 (in review) > > >> > > > > > > > >> > > > > > > > >> > > > > > On Tue, Dec 1, 2015 at 10:45 PM, Venki Korukanti < > > >> > > > > [email protected]> > > >> > > > > > wrote: > > >> > > > > > > > >> > > > > >> Sure, will merge DRILL-4111. > > >> > > > > >> > > >> > > > > >> On Tue, Dec 1, 2015 at 10:43 PM, Sudheesh Katkam < > > >> > > > [email protected]> > > >> > > > > >> wrote: > > >> > > > > >> > > >> > > > > >>> Venki, can you please commit DRILL-4111? > > >> > > > > >>> > > >> > > > > >>> Thank you, > > >> > > > > >>> Sudheesh > > >> > > > > >>> > > >> > > > > >>> > On Dec 1, 2015, at 6:22 PM, Jacques Nadeau < > > >> [email protected] > > >> > > > > >> > > > > wrote: > > >> > > > > >>> > > > >> > > > > >>> > It seems like we should also try to include: > > >> > > > > >>> > > > >> > > > > >>> > DRILL-4109 > > >> > > > > >>> > DRILL-4125 > > >> > > > > >>> > DRILL-4111 > > >> > > > > >>> > > > >> > > > > >>> > 4111 is ready to merge if someone wants to merge it. It > > >> looks > > >> > > like > > >> > > > > >>> Sudheesh > > >> > > > > >>> > just needs to commit. > > >> > > > > >>> > > > >> > > > > >>> > For 4125/4109, it seems like we should get Vicki's > > feedback > > >> if > > >> > > > those > > >> > > > > >>> > changes are good for merge or if we should punt. > > >> > > > > >>> > > > >> > > > > >>> > > > >> > > > > >>> > > > >> > > > > >>> > > > >> > > > > >>> > -- > > >> > > > > >>> > Jacques Nadeau > > >> > > > > >>> > CTO and Co-Founder, Dremio > > >> > > > > >>> > > > >> > > > > >>> > On Tue, Dec 1, 2015 at 3:59 PM, Venki Korukanti < > > >> > > > > >>> [email protected]> > > >> > > > > >>> > wrote: > > >> > > > > >>> > > > >> > > > > >>> >> I can manage the release. > > >> > > > > >>> >> > > >> > > > > >>> >> Here are the pending JIRAs so far: > > >> > > > > >>> >> > > >> > > > > >>> >> 1) DRILL-4053 > > >> > > > > >>> >> > > >> > > > > >>> >> Let me know if you have any pending patches and want to > > get > > >> > them > > >> > > > > into > > >> > > > > >>> 1.4. > > >> > > > > >>> >> > > >> > > > > >>> >> Thanks > > >> > > > > >>> >> Venki > > >> > > > > >>> >> > > >> > > > > >>> >> On Tue, Dec 1, 2015 at 10:43 AM, Parth Chandra < > > >> > > [email protected] > > >> > > > > > > >> > > > > >>> wrote: > > >> > > > > >>> >> > > >> > > > > >>> >>> +1 on creating the release branch today. > > >> > > > > >>> >>> I'd like to get DRILL-4053 in. Patch is ready and > doing > > >> one > > >> > > more > > >> > > > > >>> round of > > >> > > > > >>> >>> regression tests. > > >> > > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > > >>> >>> On Tue, Dec 1, 2015 at 9:56 AM, Jacques Nadeau < > > >> > > > [email protected] > > >> > > > > > > > >> > > > > >>> >> wrote: > > >> > > > > >>> >>> > > >> > > > > >>> >>>> It is December (already!). Seems like we should > create > > a > > >> 1.4 > > >> > > > > release > > >> > > > > >>> >>> branch > > >> > > > > >>> >>>> soon so we can get a vote going. Does someone want to > > >> > > volunteer > > >> > > > as > > >> > > > > >>> the > > >> > > > > >>> >>>> release manager? > > >> > > > > >>> >>>> > > >> > > > > >>> >>>> thanks, > > >> > > > > >>> >>>> Jacques > > >> > > > > >>> >>>> > > >> > > > > >>> >>>> -- > > >> > > > > >>> >>>> Jacques Nadeau > > >> > > > > >>> >>>> CTO and Co-Founder, Dremio > > >> > > > > >>> >>>> > > >> > > > > >>> >>> > > >> > > > > >>> >> > > >> > > > > >>> > > >> > > > > >>> > > >> > > > > >> > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Julien > > >> > > > > >> > > > >> > > > > > > > > >
