Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/298#discussion_r47573483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -105,13 +107,15 @@
long totalRecordsRead;
private final FragmentContext fragmentContext;
+ public ParquetReaderStats parquetReaderStats = new ParquetReaderStats();
--- End diff --
should we mark this as `final` ? it makes it easier for other developers
understand how it's supposed to be used. Of course, we'll have to remove the
`set to null` in the `close()` method but I guess that's fine unless of course
the close method can be called multiple times
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
