Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/300#discussion_r47582011
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
---
@@ -91,20 +91,24 @@ public void registerSchemas(SchemaConfig schemaConfig,
SchemaPlus parent) throws
}
@Override
- public Set<StoragePluginOptimizerRule>
getOptimizerRules(OptimizerRulesContext optimizerRulesContext) {
+ public Set<StoragePluginOptimizerRule>
getLogicalOptimizerRules(OptimizerRulesContext optimizerContext) {
final String defaultPartitionValue =
HiveUtilities.getDefaultPartitionValue(config.getHiveConfigOverride());
ImmutableSet.Builder<StoragePluginOptimizerRule> ruleBuilder =
ImmutableSet.builder();
-
ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnProject(optimizerRulesContext,
defaultPartitionValue));
-
ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnScan(optimizerRulesContext,
defaultPartitionValue));
+
ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnProject(optimizerContext,
defaultPartitionValue));
+
ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnScan(optimizerContext,
defaultPartitionValue));
+ return ruleBuilder.build();
+ }
+
+ @Override
+ public Set<StoragePluginOptimizerRule>
getPhysicalOptimizerRules(OptimizerRulesContext optimizerRulesContext) {
if(optimizerRulesContext.getPlannerSettings().getOptions()
.getOption(ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS).bool_val) {
- ruleBuilder.add(ConvertHiveParquetScanToDrillParquetScan.INSTANCE);
+ ImmutableSet.of(ConvertHiveParquetScanToDrillParquetScan.INSTANCE);
--- End diff --
return ImmutableSet.of(ConvertHiveParquetScanToDrillParquetScan.INSTANCE) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
