Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/310#discussion_r48306306
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -391,7 +397,10 @@ private void parseAndRunPhysicalPlan(final String
json) throws ExecutionSetupExc
private void runPhysicalPlan(final PhysicalPlan plan) throws
ExecutionSetupException {
validatePlan(plan);
setupSortMemoryAllocations(plan);
- acquireQuerySemaphore(plan);
+ if (queuingEnabled) {
+ acquireQuerySemaphore(plan);
+ }
+ recordNewState(QueryState.STARTING);
--- End diff --
If the initialState is STARTING won't this fail (state transition from
STARTING to STARTING is invalid given the fall-through)? The
recordNewState(STARTING) should be inside the if condition, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
