GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/321
DRILL-4257: Fix StoragePluginRegistry clean-up behavior
Fix StoragePluginRegistry clean-up behavior and misc clean up.
- Create the storage plugin registry using a Drill configuration parameter
to be able to replace the registry implementation.
- Change StoragePluginRegistry into an interface and move the
implementation to an impl class.
- Write documentation for StoragePluginRegistry.
- Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure
that Drillbit closes registry.
- Misc Drillbit code reorganization so that fields are at top of class (and
static methods at bottom).
- Update DrillConfig to support reflection-based creation of storage plugin
objects
- Remove final from DrillConfig so that application developers can extend
config object.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacques-n/drill DRILL-4257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit f172aed0380465c6eea480ddcd540038ebbe6a22
Author: Jacques Nadeau <[email protected]>
Date: 2016-01-10T01:48:26Z
DRILL-4257: Fix StoragePluginRegistry clean-up behavior and misc clean up.
- Create the storage plugin registry using a Drill configuration parameter
to be able to replace the registry implementation.
- Change StoragePluginRegistry into an interface and move the
implementation to an impl class.
- Write documentation for StoragePluginRegistry.
- Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure
that Drillbit closes registry.
- Misc Drillbit code reorganization so that fields are at top of class (and
static methods at bottom).
- Update DrillConfig to support reflection-based creation of storage plugin
objects
- Remove final from DrillConfig so that application developers can extend
config object.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
