Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/319#discussion_r49780505
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java
---
@@ -286,7 +286,7 @@ public void flush(boolean schemaChanged) throws
IOException {
// sender has acknowledged the terminate request. After sending
the last batch, all further batches are
// dropped.
// 3. Partitioner thread is interrupted due to cancellation of
fragment.
- final boolean isLastBatch = isLast || terminated ||
Thread.currentThread().isInterrupted();
+ final boolean isLastBatch = isLast ||
Thread.currentThread().isInterrupted();
--- End diff --
If the sender is not sending the "last batch" message, could we be sure
that no receiver is waiting for it ? Like we discussed it seems the
MergingReceiver does not behave the same as UnorderedReceiver in the sense that
the MR waits for the last batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
