Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/325#discussion_r49916936
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
---
@@ -180,39 +179,39 @@ private void init() throws IOException {
chunksMapping = Maps.newHashMap();
chunksInverseMapping = Maps.newLinkedHashMap();
if (isShardedCluster(client)) {
- MongoDatabase db = client.getDatabase(CONFIG);
- MongoCollection<Document> chunksCollection =
db.getCollection(CHUNKS);
+ MongoDatabase db = client.getDatabase(DrillMongoConstants.CONFIG);
--- End diff --
Whole point here was to avoid using an interface for constants and to avoid
doing a static/wildcard import, following [Google guidelines](
https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports).
However, if this is taken as a show stopper, I can switch to static imports,
disliking myself later ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
