Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/327#discussion_r50182483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -56,22 +60,83 @@
private final DrillConfig config;
boolean useIP = false;
private final boolean allowPortHunting;
+ private final BufferAllocator userAllocator;
+ private final BufferAllocator controlAllocator;
+ private final BufferAllocator dataAllocator;
+
public ServiceEngine(ControlMessageHandler controlMessageHandler,
UserWorker userWorker, BootStrapContext context,
WorkEventBus workBus, WorkerBee bee, boolean allowPortHunting)
throws DrillbitStartupException {
+ userAllocator = newAllocator(context, "rpc:user",
"drill.exec.rpc.user.server.memory.reservation",
+ "drill.exec.rpc.user.server.memory.maximum");
+ controlAllocator = newAllocator(context, "rpc:bit-control",
+ "drill.exec.rpc.bit.server.memory.control.reservation",
"drill.exec.rpc.bit.server.memory.control.maximum");
+ dataAllocator = newAllocator(context, "rpc:bit-control",
--- End diff --
Someone argued recently that it doesn't make sense to put everything there
and I am in agreement. I've started adopting keeping strings where they are
relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
