Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/336#discussion_r51083291
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/util/Text.java ---
    @@ -0,0 +1,612 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.util;
    +
    +import java.io.DataInput;
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +import java.nio.CharBuffer;
    +import java.nio.charset.CharacterCodingException;
    +import java.nio.charset.Charset;
    +import java.nio.charset.CharsetDecoder;
    +import java.nio.charset.CharsetEncoder;
    +import java.nio.charset.CodingErrorAction;
    +import java.nio.charset.MalformedInputException;
    +import java.text.CharacterIterator;
    +import java.text.StringCharacterIterator;
    +import java.util.Arrays;
    +
    +import com.fasterxml.jackson.core.JsonGenerationException;
    +import com.fasterxml.jackson.core.JsonGenerator;
    +import com.fasterxml.jackson.databind.SerializerProvider;
    +import com.fasterxml.jackson.databind.annotation.JsonSerialize;
    +import com.fasterxml.jackson.databind.ser.std.StdSerializer;
    +
    +/**
    + * A simplified byte wrapper similar to Hadoop's Text class without all 
the dependencies. Lifted from Hadoop 2.7.1
    + */
    +@JsonSerialize(using = Text.TextSerializer.class)
    +public class Text {
    --- End diff --
    
    I took this from the source jar of the Hadoop 2.7.1 release, not a 
particular commit. That is why I noted that origin in the comment at the top of 
the file. Looking at how Hadoop tags, that looks it is the same as 
ac0538aac347bfd97cc0dee1db49db503c15f1d9 but I think the version number should 
suffice. Good idea on the two commits. I'll do that in the future if I need to 
do this kind of thing again. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to