Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51528367
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -118,13 +133,34 @@ public boolean apply(@Nullable FileStatus status) {
}
}));
- return create(nonDirectories, null, selectionRoot);
+ final FileSelection fileSel = create(nonDirectories, null,
selectionRoot);
--- End diff --
I did not change the existing create() call .. it was passing null for the
list of files. I think it is ok because FileStatus contains the Path which
reflects the file name. It also seems that if either the list of files is null
or the list of statuses is null, the functions getFiles() or getStatuses() can
compute them on the first invocation and save for future use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
