By the way, I believe you can skip the enforcer plugin execution with -Denforcer.skip=true On Feb 8, 2016 8:27 PM, "Jacques Nadeau" <jacq...@dremio.com> wrote:
> I'm against removing the check as it is actually building a functionally > invalid jdbc jar file. Any tests using that jdbc jar are invalid since > they include different code than the release jdbc driver. This caused major > regressions in the 1.4 jdbc driver. > On Feb 8, 2016 4:48 PM, "Jason Altekruse" <altekruseja...@gmail.com> > wrote: > >> Hey Sudheesh, >> >> Unfortunately it will not fix this issue, it is related specifically to >> how >> the addition of the enforcer (for currently unknown reasons) caused the >> release profile to fail in a new way. I hadn't run into issues with >> enforcer itself actually failing with my version of Maven. >> >> I would be in favor of a flag to make it easier to disable this check, we >> can even change the message to tell people about the flag (it could be >> updated now to suggest upgrading maven), but I do think we should keep >> this >> enforcer rule on by default as the 1.4 release had a pretty bloated JAR >> because this wasn't being checked. >> >> - Jason >> >> On Mon, Feb 8, 2016 at 4:23 PM, Sudheesh Katkam <skat...@maprtech.com> >> wrote: >> >> > @Jason, does DRILL-4375 < >> https://issues.apache.org/jira/browse/DRILL-4375> >> > address this issue as well? >> > >> > > On Feb 8, 2016, at 4:19 PM, Sudheesh Katkam <skat...@maprtech.com> >> > wrote: >> > > >> > > On one of the Linux VMs, when I run mvn clean install -DskipTests >> > -Pmapr, I get this error with 3.3.x (but not with 3.2.x). Weird. >> > > >> > > Should we disable the rule until we figure out the cause? >> > > >> > > - Sudheesh >> > > >> > >> On Feb 2, 2016, at 6:11 AM, Jacques Nadeau <jacq...@dremio.com >> <mailto: >> > jacq...@dremio.com>> wrote: >> > >> >> > >> This is a bug in maven we haven't figured out yet how we're causing. >> > >> Upgrading to Maven 3.3.x fixes it. >> > >> On Feb 2, 2016 2:18 AM, "Arina Yelchiyeva" < >> arina.yelchiy...@gmail.com >> > <mailto:arina.yelchiy...@gmail.com>> >> > >> wrote: >> > >> >> > >>> Hi all! >> > >>> >> > >>> Just pulled recent changes from master (revision number >> > >>> 1b96174b1e5bafb13a873dd79f03467802d7c929) and mvn clean install >> > -DskipTests >> > >>> failed with the following error: >> > >>> >> > >>> *[ERROR] Failed to execute goal >> > >>> org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce >> > >>> (enforce-jdbc-jar-compactness) on project drill-jdbc-all: Some >> Enforcer >> > >>> rules have failed. Look above for specific messages explaining why >> the >> > rule >> > >>> failed.* >> > >>> >> > >>> *[WARNING] Rule 0: >> org.apache.maven.plugins.enforcer.RequireFilesSize >> > >>> failed with message:* >> > >>> *The file drill-jdbc-all-1.5.0-SNAPSHOT.jar is outside the expected >> > size >> > >>> range. * >> > >>> >> > >>> *This is likely due to you adding new dependencies to a java-exec >> and >> > not >> > >>> updating the excludes in this module. This is important as it >> > minimizes the >> > >>> size of the dependency of Drill application users.* >> > >>> >> > >> *F:\git_repo\drill\exec\jdbc-all\target\drill-jdbc-all-1.5.0-SNAPSHOT.jar >> > >>> size (44664290) too large. Max. is 20000000 >> > >>> >> > >> F:\git_repo\drill\exec\jdbc-all\target\drill-jdbc-all-1.5.0-SNAPSHOT.jar* >> > >>> >> > >>> Had to change <maxsize>20000000</maxsize> -> >> > <maxsize>50000000</maxsize> in >> > >>> jdbc-all pom.xml to build the project. >> > >>> >> > >>> Do we need to create jira for this or it's already being fixed? >> > >>> >> > >>> Kind regards >> > >>> Arina >> > >>> >> > > >> > >> > >> >
