Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52953882
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -120,7 +120,7 @@ drill.exec: {
         affinity.factor: 1.2
       },
       sys.store.provider: {
    -    class: "org.apache.drill.exec.store.sys.zk.ZkPStoreProvider",
    +    class: 
"org.apache.drill.exec.store.sys.store.provider.ZookeeperPersistentStoreProvider",
    --- End diff --
    
    I second on Sudheesh's concern. Unless there is a strong reason that we 
have to make a breaking change such that "all references to ZkPStoreProvider 
will fail following this patch", I feel we need to think twice before we make 
such change.  Is this the only way that we can go? Have we assessed the impact 
to Drill's current users (After all, Drill is post 1.0 release)? Do we have a 
well-documented plan to help them to migrate, if the backward compatibility is 
broken in new release?
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to