Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53340898
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -87,9 +87,6 @@ public ScanBatch getBatch(FragmentContext context,
ParquetRowGroupScan rowGroupS
newColumns.add(column);
}
}
- if (newColumns.isEmpty()) {
--- End diff --
So, to clarify, the reason you removed the check for newColumns.isEmpty()
is that if the column list is empty, the underlying ParquetRecordReader will
handle it correctly by produce 1 default column (probably a NullableInt column)
?
Was this check for isEmpty() only present in the Parquet scan ? or should
other readers need modification too ?
I think it would be good to add comments about how the NULL and empty
column list are being handled by each data source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
