Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53533100
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
@@ -216,6 +217,20 @@ public void eval() {
}
@FunctionTemplate(names = {"char_length", "character_length", "length"},
scope = FunctionScope.SIMPLE, nulls = NullHandling.NULL_IF_NULL)
+ public static class DummyCharLength implements DrillSimpleFunc {
--- End diff --
As you can see, there are a bunch of dummy functions added in.
As here:
https://github.com/hsuanyi/incubator-drill/blob/DRILL-4372_For_Review/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java#L101
If there is no a dummy, this line cannot find a DrillFuncHolder which
matches the given SqlOperatorBinding.
Their bodies are empty and it is fine because later in DrillOptiq, the
functions which will actually be used will be chosen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
