Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54922761
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
---
@@ -100,8 +108,13 @@ public void onMatch(RelOptRuleCall ruleCall) {
*/
private boolean containsAvgStddevVarCall(List<AggregateCall>
aggCallList) {
for (AggregateCall call : aggCallList) {
- if (call.getAggregation() instanceof SqlAvgAggFunction
- || call.getAggregation() instanceof SqlSumAggFunction) {
+ SqlAggFunction sqlAggFunction = call.getAggregation();
+ if(sqlAggFunction instanceof DrillCalciteSqlWrapper) {
--- End diff --
There are a bunch of unwrap calls like this. Is there a way to avoid this?
Otherwise, devs need to aware of this unwrapping for *all* Calcite (SQL
standard) functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
