Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/372#discussion_r55125265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLengthValuesColumn.java
---
@@ -81,6 +112,14 @@ public boolean skipReadyToReadPositionUpdate() {
return false;
}
+ // decimalLengths list is part of a near-term fix for DRILL-4184.
+ // Decimal[23]8SparseVector classes are fixed width vectors, without
ability to "remember" offsets of
+ // (variable width) field sizes. so, we "remember" the array sizes in
decimalLengths (also used to
+ // "remember" whether a value was null, for nullable decimal columns).
+ // TODO: storage of decimal values should support variable length values
in a much cleaner way than this,
+ // perhaps with a new variable width Decimal vector class.
+ protected ArrayList<Integer> decimalLengths = new ArrayList();
--- End diff --
please put class members at the top of the class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
