Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/407#discussion_r55561579
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 
---
    @@ -527,6 +532,52 @@ public void testUnionAllRightEmptyJson() throws 
Exception {
           .build().run();
       }
     
    +  @Test
    +  public void testUnionAllLeftEmptyJson() throws Exception {
    --- End diff --
    
    Are there any union-all tests with  WHERE 1 = 0 filters on the left and/or 
right inputs ?  If not, could you add such tests ?  We should distinguish 
between a truly empty input vs. one that occurs as a result of a False filter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to