GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/430
DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspâ¦
Since we have to have our own implementations of hash functions, UNIT tests
should guarantee the correctness of implementation. Due to hash function is
critical to distributed SQL engine's performance, make changes to allow future
adding/testing new hash function to be smooth.
1, Implement Murmur3 to work on DrillBuf and long(double), both avoid
object or extra buffer creation.
2, fix xxHash
3, Point hash functions in hash32, hash64, hash32AsDouble and
hash64AsDouble to HashHelper.hash32|64
4, Test Correctness of the hash functions by comparing with original c
implementation's generated hash results.
Testing vectors are generated from https://github.com/chunhui-shi/smhasher
by running these commands after build:
gethash Murmur3F --json=MurmurHash3
gethash xxHash64 --json=XXHash
5, Adding tests to cover Hash**WithSeed.
6, Fix DRILL-4478 which prevent binar_string function working correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill hash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #430
----
commit 2210279618dee857df32f28c647ee8ec8409a44a
Author: chunhui-shi <[email protected]>
Date: 2016-03-15T17:36:54Z
DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspondent
unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
