Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/446#discussion_r57518713
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java ---
@@ -82,15 +79,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
} else {
// need to make buffer copy, otherwise netty will try to refill
this buffer if we move the readerIndex forward...
// TODO: Can we avoid this copy?
- ByteBuf outBuf;
- try {
- outBuf = allocator.buffer(length);
- } catch (OutOfMemoryException e) {
- logger.warn("Failure allocating buffer on incoming stream due
to memory limits. Current Allocation: {}.", allocator.getAllocatedMemory());
- in.resetReaderIndex();
- outOfMemoryHandler.handle();
- return;
- }
+ ByteBuf outBuf = allocator.buffer(length);
--- End diff --
I will look into that. So far, when I was trying to reproduce the issue
through Sqlline I would get an OutOfMemory error in a different place (earlier
?) of the RPC layer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
