Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/445#discussion_r58234800
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java 
---
    @@ -177,6 +182,18 @@ public void run() {
         });
       }
     
    +  /** If we are in distributed mode, disallow using loopback address to 
register new drillbit
    +   *  unless zookeeper is on the same node with drillbit. */
    +  private void checkLoopbackAddress(String address) throws 
DrillbitStartupException, UnknownHostException {
    +    if (isDistributedMode) {
    +      String coordAddress = 
StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION), ":");
    +      if (!InetAddress.getByName(coordAddress).isLoopbackAddress()
    --- End diff --
    
    In distributed mode, no bit should be allowed to register with a loopback 
address.
    
    If bit A is allowed to register with a loopback address and bit B tries to 
communicate with bit A, bit B would be sending messages to itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to