GitHub user jcmcote opened a pull request:
https://github.com/apache/drill/pull/457
Drill 4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR
All the functions using the java.util.regex.Matcher are currently creating
Java string objects to pass into the matcher.reset().
However this creates unnecessary copy of the bytes and a Java string object.
The matcher uses a CharSequence, so instead of making a copy we can create
an adapter from the DrillBuffer to the CharSequence interface.
Gains of 25% in execution speed are possible when going over VARCHAR of 36
chars. The gain will be proportional to the size of the VARCHAR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcmcote/drill DRILL-4573
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #457
----
commit 6faed2f380385390c270c6699c653956b8364826
Author: Jacques Nadeau <[email protected]>
Date: 2016-01-19T01:42:33Z
DRILL-4278: Fix issue where WorkspaceConfig was not returning consistent
hashCode()s for equal objects.
commit 3745a8cc6aaff6254cb2e27db50beb2f08c2f7d5
Author: Jacques Nadeau <[email protected]>
Date: 2016-01-19T01:42:33Z
DRILL-4278: Heap memory leak issues
- Fix issue where WorkspaceConfig was not returning consistent hashCode()s
for equal objects.
- Fix issue where we were misusing recycler causing object reference leaks
commit b0045c639a831945b64c8038ff37624cb8f62239
Author: jean-claude cote <[email protected]>
Date: 2016-01-21T00:55:14Z
Merge branch 'DRILL-4278' of https://github.com/jacques-n/drill
commit 27e617cb5562dca6ec2f61eae4a1755eff50b85f
Author: jean-claude cote <[email protected]>
Date: 2016-02-10T12:02:16Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/drill
commit 2afba2ca8fd05b5d18c1b40d5717cfcfc4e186cf
Author: jean-claude cote <[email protected]>
Date: 2016-04-01T21:13:14Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/drill
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
