Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/463#discussion_r58821834
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java ---
@@ -84,7 +115,7 @@ public void operationComplete(ChannelFuture future)
throws Exception {
if (!future.isSuccess()) {
removeFromMap(coordinationId);
if (future.channel().isActive()) {
- throw new RpcException("Future failed") ;
+ throw new RpcException("Future failed");
--- End diff --
Since the future did not succeed, should this
`setException(future.cause())`? There would be no outcome for the `handler`
otherwise, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
