Github user parthchandra commented on the pull request:
https://github.com/apache/drill/pull/398#issuecomment-214433058
I have two problems with this patch (apart from it being just too big to
review)
1) Building against 0.1-SNAPSHOT of a project that is in rapid development
is a courageous decision (I would rather not board a train while it is moving
at full speed). The current patch also does not build as there is no artifact
for Arrow 0.1-SNAPSHOT.
2) I see that the entire memory module of Drill is gone. I don't think that
drill memory management and accounting should be outsourced to Arrow. I can see
needing to use ArrowBuf for value vectors but removing the entire memory module
is not OK. I can see other uses of Direct/Heap memory (caching metadata for
example) that should be managed under a Drill resource manager. This ties back
to #1. Arrow needs to get its design figured out to allow Drill and other
projects to manage their resources while providing a 'reference'
implementation.
-1 until we resolve this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
