Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/481#discussion_r63602468
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
 ---
    @@ -1280,6 +1280,43 @@ public void eval() {
         } // end of eval
       }
     
    +  @FunctionTemplate(name = "split", scope = FunctionScope.SIMPLE, nulls = 
NullHandling.NULL_IF_NULL)
    +  public static class Split implements DrillSimpleFunc {
    +    @Param  VarCharHolder input;
    +    @Param  VarCharHolder delimiter;
    +
    +    @Workspace char splitChar;
    --- End diff --
    
    How about reusing the Splitter?
    
    Create a workspace splitter once in setup, and use in eval.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to