Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64629211
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -110,6 +110,7 @@ drill.exec: {
       http: {
         enabled: true,
         ssl_enabled: false,
    +    cors_enabled: true,
    --- End diff --
    
    perhaps we should consider extending cors configuration with 
    ```
    http: {
      cors: {
        enabled: true,
        allowedOrigins: ['*.mydomain.com', '*.someother.net'], --> configures 
Access-Control-Allow-Origin
        allowedMethods: ['option', 'get', 'post', 'some-other'], --> configures 
 Access-Control-Allow-Methods
        allowedHeaders: ['some-allowed-header'], --> configures 
Access-Control-Expose-Headers 
        credentials: true | false -- >  configures 
Access-Control-Allow-Credentials
      }
    }
    ```
    I am probably missing few in the list but I find these options essential.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to