Github user adityakishore commented on a diff in the pull request:

    https://github.com/apache/drill/pull/443#discussion_r65254026
  
    --- Diff: 
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
 ---
    @@ -21,34 +21,36 @@
     import java.util.Set;
     
     import org.apache.calcite.schema.SchemaPlus;
    -
     import org.apache.drill.common.JSONOptions;
     import org.apache.drill.exec.ops.OptimizerRulesContext;
     import org.apache.drill.exec.server.DrillbitContext;
     import org.apache.drill.exec.store.AbstractStoragePlugin;
     import org.apache.drill.exec.store.SchemaConfig;
     import org.apache.drill.exec.store.StoragePluginOptimizerRule;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.client.Connection;
     
     import com.fasterxml.jackson.core.type.TypeReference;
     import com.fasterxml.jackson.databind.ObjectMapper;
     import com.google.common.collect.ImmutableSet;
     
     public class HBaseStoragePlugin extends AbstractStoragePlugin {
    -  static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(HBaseStoragePlugin.class);
    +  private static final HBaseConnectionManager hbaseConnectionManager = 
HBaseConnectionManager.INSTANCE;
    --- End diff --
    
    The HBaseConnectionManager is static, and is essentially a connection pool 
which maintains one HBase connection per storage plugin instance as you 
recommend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to