GitHub user vkorukanti opened a pull request:
https://github.com/apache/drill/pull/524
DRILL-4724: Improvements to InfoSchema RecordGenerator needed for DRILL-4714
1. Add support for pushing the filter on following fields into
InfoSchemaRecordGenerator:
- CATALOG_NAME
- COLUMN_NAME
2. Pushdown LIKE with ESCAPE. Add test
TestInfoSchemaFilterPushDown#testFilterPushdown_LikeWithEscape
3. Add a method visitCatalog() to InfoSchemaRecordGenerator to decide
whether to explore the catalog or not
4. Refactor CATALOG_DESCRIPTION and CATALOG_CONNECT as constant strings in
InfoSchemaConstants.java
5. Update TestInfoSchemaFilterPushDown#testPartialFilterPushDownWithProject
as
we are now pushing the filter on COLUMN_NAME field
6. Cleanup:
Rename RecordGenerator -> InfoSchemaRecordGenerator
Add comments in RecordGenerator
Rename SelectedTable -> InfoSchemaTableType
@parthchandra Can you please review this change?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vkorukanti/drill DRILL-4725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #524
----
commit f331507af044d42b74b1fedbf7b9de8adc861334
Author: vkorukanti <[email protected]>
Date: 2016-06-09T07:00:31Z
DRILL-4724: Improvements to InfoSchema RecordGenerator needed for DRILL-4714
1. Add support for pushing the filter on following fields into
InfoSchemaRecordGenerator:
- CATALOG_NAME
- COLUMN_NAME
2. Pushdown LIKE with ESCAPE. Add test
TestInfoSchemaFilterPushDown#testFilterPushdown_LikeWithEscape
3. Add a method visitCatalog() to InfoSchemaRecordGenerator to decide
whether to explore the catalog or not
4. Refactor CATALOG_DESCRIPTION and CATALOG_CONNECT as constant strings in
InfoSchemaConstants.java
5. Update TestInfoSchemaFilterPushDown#testPartialFilterPushDownWithProject
as
we are now pushing the filter on COLUMN_NAME field
6. Cleanup:
Rename RecordGenerator -> InfoSchemaRecordGenerator
Add comments in RecordGenerator
Rename SelectedTable -> InfoSchemaTableType
Change-Id: I0b2e16d04cb72fe3ce5961f5f357a00655f1cb05
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
