DRILL-4733 patch is reviewed and tested, so I will include it in the release (pending a minor update to the unit test).
A regression was reported for a few decimal tests, see https://issues.apache.org/jira/browse/DRILL-4746, which was caused by DRILL-3149, so I will be excluding this commit from the release. I hope to send out a release candidate tomorrow morning. -Aman On Mon, Jun 20, 2016 at 6:03 PM, Aman Sinha <[email protected]> wrote: > Quick update: DRILL-4733 ( > https://issues.apache.org/jira/browse/DRILL-4733) is a regression that > Drill QA team found today, so I will have to wait to have it resolved for > 1.7.0 before creating a release candidate. > > > On Mon, Jun 20, 2016 at 1:52 PM, Johannes Schulte < > [email protected]> wrote: > >> Speaking for DRILL-4574: >> >> I can get a simple mvn test to run, even on the master. I always get >> >> [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack >> (unpack-vector-types) on project drill-java-exec: Artifact has not been >> packaged yet. When used on reactor artifact, unpack should be executed >> after packaging: see MDEP-98. -> [Help 1] >> >> I tried some things but nothing so far worked. It's not really unit tests >> failing, it's the building. If somebody could check it out and run the >> tests i'd be really happy >> >> On Mon, Jun 20, 2016 at 5:53 AM, Aman Sinha <[email protected]> wrote: >> >> > For the fixes that were committed in the last few days, could the >> > committers close the pull requests and update the JIRAs with 'Fixed' >> status >> > for 1.7. >> > >> > For the remaining JIRAs mentioned in this thread, here are the status: >> > >> > 1. DRILL-4525 (BETWEEN clause on Date and Timestamp): the right place >> to >> > fix this would be an enhancement in Calcite. In the meantime, a >> workaround >> > is to do explicit CASTing as suggested in the JIRA. >> > 2. DRILL-4653 (Skip malformed JSON): mostly reviewed but needs some >> more >> > review/testing. >> > 3. DRILL-4704 (Decimal type): unit test being added. needs review. >> > 4. DRILL-4574 (Avro): Rebased but unit tests failing for some other >> > reason. >> > >> > I would like to finalize the content by EOD tomorrow. Clearly, 1 has >> been >> > pushed out of 1.7 and I think it would be quite a stretch to get the >> rest >> > in, so I would be in favor of pushing 2, 3, 4 into the next release. >> > However, since all 3 have good momentum going right now, let's try to >> get >> > the pending issues resolved soon. >> > >> > Thanks ! >> > Aman >> > >> > >> > On Thu, Jun 16, 2016 at 1:57 PM, Aman Sinha <[email protected]> >> wrote: >> > >> > > It does look like DRILL-4574 was previously reviewed and ready to be >> > > merged. Right now it will need to be rebased on master branch. Since >> > this >> > > is in the Avro plugin, I am unsure about the types of tests that >> need to >> > > be run.. I would prefer if Jason Altekruse could take a quick look and >> > > merge into master if everything looks ok. >> > > >> > > On Thu, Jun 16, 2016 at 1:22 PM, Johannes Schulte < >> > > [email protected]> wrote: >> > > >> > >> Hi, >> > >> >> > >> https://github.com/apache/drill/pull/459 ( >> > >> https://issues.apache.org/jira/browse/DRILL-4574) is still not >> merged >> > >> but i >> > >> think it is ready for a merge. Are there any other actions necessary? >> > >> >> > >> Johannes >> > >> >> > >> On Thu, Jun 16, 2016 at 8:07 PM, Jinfeng Ni <[email protected]> >> > >> wrote: >> > >> >> > >> > I will review the Sean's PR for DRILL-4525, since it's a regression >> > from >> > >> > 1.6. >> > >> > >> > >> > >> > >> > On Thu, Jun 16, 2016 at 9:39 AM, rahul challapalli >> > >> > <[email protected]> wrote: >> > >> > > I would like to have DRILL-4525 as this is a regression (most >> likely >> > >> from >> > >> > > 1.6). Any takers for this? >> > >> > > >> > >> > > - Rahul >> > >> > > >> > >> > > On Wed, Jun 15, 2016 at 4:03 PM, Aman Sinha < >> [email protected]> >> > >> > wrote: >> > >> > > >> > >> > >> I can take a look at DRILL-4653. >> > >> > >> >> > >> > >> Could someone familiar with the Decimal type take a look at >> > >> DRILL-4704 ? >> > >> > >> Agree with Dave that it is a simple case that should be fixed >> > (note, >> > >> > >> however, that decimal is disabled by default currently). >> > >> > >> >> > >> > >> >> > >> > >> On Wed, Jun 15, 2016 at 3:12 PM, Subbu Srinivasan < >> > >> > [email protected] >> > >> > >> > >> > >> > >> wrote: >> > >> > >> >> > >> > >> > Who can review >> https://issues.apache.org/jira/browse/DRILL-4653 >> > ? >> > >> > >> > >> > >> > >> > On Wed, Jun 15, 2016 at 1:37 PM, Parth Chandra < >> > >> [email protected] >> > >> > > >> > >> > >> > wrote: >> > >> > >> > >> > >> > >> > > +1 on the 1.7 release >> > >> > >> > > >> > >> > >> > > I'm reviewing the following and hope to get them in the >> release >> > >> > before >> > >> > >> > > cutoff: >> > >> > >> > > https://issues.apache.org/jira/browse/DRILL-2593 >> > >> > >> > > https://issues.apache.org/jira/browse/DRILL-4309 >> > >> > >> > > >> > >> > >> > > >> > >> > >> > > >> > >> > >> > > On Wed, Jun 15, 2016 at 1:20 PM, Jinfeng Ni < >> > >> [email protected]> >> > >> > >> > wrote: >> > >> > >> > > >> > >> > >> > > > I'm reviewing a follow-up PR [1] for DRILL-4573. I think >> we >> > >> need >> > >> > get >> > >> > >> > > > it merged in, since it's a regression in terms of query >> > >> > correctness >> > >> > >> > > > from release 1.6. >> > >> > >> > > > >> > >> > >> > > > [1] https://github.com/apache/drill/pull/512 >> > >> > >> > > > >> > >> > >> > > > On Wed, Jun 15, 2016 at 12:21 PM, Dave Oshinsky < >> > >> > >> > [email protected] >> > >> > >> > > > >> > >> > >> > > > wrote: >> > >> > >> > > > > This is a pretty basic bug affecting decimal values, >> with a >> > >> > simple >> > >> > >> > fix: >> > >> > >> > > > > https://issues.apache.org/jira/browse/DRILL-4704 >> > >> > >> > > > > >> > >> > >> > > > > It would be great if it could be reviewed. >> > >> > >> > > > > >> > >> > >> > > > > -----Original Message----- >> > >> > >> > > > > From: Aman Sinha [mailto:[email protected]] >> > >> > >> > > > > Sent: Wednesday, June 15, 2016 3:15 PM >> > >> > >> > > > > To: dev >> > >> > >> > > > > Subject: Time for a 1.7 release >> > >> > >> > > > > >> > >> > >> > > > > Hello everyone, >> > >> > >> > > > > >> > >> > >> > > > > A 1.7 release is quite overdue ! I would like to get >> the >> > >> ball >> > >> > >> > > > rolling... >> > >> > >> > > > > >> > >> > >> > > > > In preparation, could developers please close the pull >> > >> > requests >> > >> > >> > that >> > >> > >> > > > have already been merged into master ? This will give me >> a >> > >> better >> > >> > >> > sense >> > >> > >> > > of >> > >> > >> > > > what is in progress. >> > >> > >> > > > > >> > >> > >> > > > > Can all the folks working on open issues let me know >> if >> > >> there >> > >> > are >> > >> > >> > any >> > >> > >> > > > JIRAs you would like to get into the release? >> > >> > >> > > > > >> > >> > >> > > > > Tentatively, I am thinking beginning of next week to >> > get a >> > >> > >> release >> > >> > >> > > > candidate. >> > >> > >> > > > > >> > >> > >> > > > > thanks, >> > >> > >> > > > > -Aman >> > >> > >> > > > > >> > >> > >> > > > > >> > >> > >> > > > > >> > >> > >> > > > > ***************************Legal >> > >> > >> > Disclaimer*************************** >> > >> > >> > > > > "This communication may contain confidential and >> privileged >> > >> > >> material >> > >> > >> > > for >> > >> > >> > > > the >> > >> > >> > > > > sole use of the intended recipient. Any unauthorized >> > review, >> > >> > use or >> > >> > >> > > > distribution >> > >> > >> > > > > by others is strictly prohibited. If you have received >> the >> > >> > message >> > >> > >> by >> > >> > >> > > > mistake, >> > >> > >> > > > > please advise the sender by reply email and delete the >> > >> message. >> > >> > >> Thank >> > >> > >> > > > you." >> > >> > >> > > > > >> > >> > >> > >> > >> >> ********************************************************************** >> > >> > >> > > > >> > >> > >> > > >> > >> > >> > >> > >> > >> >> > >> > >> > >> >> > > >> > > >> > >> > >
