Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/540#discussion_r69635786
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -156,12 +156,18 @@ protected void readField(long
recordsToReadInThisPass) {
recordsReadInThisIteration = Math.min(pageReader.currentPageCount
- pageReader.valuesRead, recordsToReadInThisPass -
valuesReadInCurrentPass);
- for (int i = 0; i < recordsReadInThisIteration; i++){
- try {
- valueVec.getMutator().setSafe(valuesReadInCurrentPass + i,
pageReader.dictionaryValueReader.readLong());
- } catch ( Exception ex) {
- throw ex;
+ if (usingDictionary) {
--- End diff --
Why is this check added only for this reader?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---