Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/541#discussion_r69991328
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
      * Parses a drop view statement.
      * DROP VIEW view_name;
      */
    -SqlNode SqlDropView() :
    +SqlNode SqlDropViewIfExists() :
     {
         SqlParserPos pos;
    +    boolean viewExistenceCheck = false;
     }
     {
         <DROP> { pos = getPos(); }
         <VIEW>
    +    [ <IF> <EXISTS> { viewExistenceCheck = true; } ]
         {
    -        return new SqlDropView(pos, CompoundIdentifier());
    +        return new SqlDropView(pos, CompoundIdentifier(), 
viewExistenceCheck);
    --- End diff --
    
    Should this be `return new SqlDropViewIfExists(..);`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to