Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r70493693
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
@@ -81,6 +83,11 @@
new RangeLongValidator("planner.identifier_max_length", 128 /* A
minimum length is needed because option names are identifiers themselves */,
Integer.MAX_VALUE,
DEFAULT_IDENTIFIER_MAX_LENGTH);
+ public static final OptionValidator
FILTER_MIN_SELECTIVITY_ESTIMATE_FACTOR = new
MinRangeDoubleValidator("planner.filter.min_selectivity_estimate_factor",
--- End diff --
Thinking about this more, we should probably remove the term 'Filter' from
the option. Calcite's RelMdSelectivity has a default implementation for
various Rels, not just Filter. In the future we could potentially use the same
min and max bounds for other Rels. What do you think ? If you agree, other
places need to be modified too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
