Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70537956
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -607,7 +607,14 @@ public long getRowCount() {
fileSet = Sets.newHashSet(fileNames);
}
- if (fileNames.isEmpty()) {
+ List<String> finalFileNames;
+ if (fileSet != null) {
+ finalFileNames = Lists.newArrayList(fileSet);
--- End diff --
I see the need to remove duplicates and the confusion comes from old code.
Is it reasonable to change existing code, and only keep fileSet in all cases?
Keep fileName and fileSet seems to be a bit confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
