Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/482#discussion_r70672079
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() {
}
/**
+ * If cluster version is the same as default, update option to current
drillbit version.
+ */
+ private void checkAndUpdateClusterVersionOption(OptionManager
optionManager, DrillbitEndpoint drillbitEndpoint) {
+ OptionValue versionOption =
optionManager.getOption(ExecConstants.CLUSTER_VERSION);
+ OptionValidator validator =
SystemOptionManager.getValidator(ExecConstants.CLUSTER_VERSION);
+ if (versionOption.equals(validator.getDefault())) {
+ optionManager.setOption(OptionValue.createOption(
--- End diff --
I don't think using a system option is the right way to detect version
conflicts; cluster wide upgrade and restart will cause all drillbits to
generate a warning because system options are persisted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
