Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/553#discussion_r72296459
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -387,16 +378,35 @@ protected void doOnMatch(RelOptRuleCall call, Filter
filterRel, Project projectR
condition = condition.accept(reverseVisitor);
pruneCondition = pruneCondition.accept(reverseVisitor);
- if (checkForSingle && isSinglePartition && !wasAllPartitionsPruned) {
+ if (descriptor.supportsMetadataCachePruning() &&
!wasAllPartitionsPruned) {
// if metadata cache file could potentially be used, then assign a
proper cacheFileRoot
- String path = "";
- for (int j = 0; j <= maxIndex; j++) {
- path += "/" + spInfo[j];
+ int index = -1;
+ if (!matchBitSet.isEmpty()) {
+ String path = "";
+ index = matchBitSet.length() - 1;
+
+ for (int j = 0; j < matchBitSet.length(); j++) {
+ if (!matchBitSet.get(j)) {
+ // stop at the first index with no match and use the
immediate
+ // previous index
+ index = j-1;
+ break;
+ }
+ }
+ for (int j=0; j <= index; j++) {
+ path += "/" + spInfo[j];
+ }
+ cacheFileRoot = descriptor.getBaseTableLocation() + path;
--- End diff --
cacheFileRoot is set within 'IF' branch. Are we going to get a null for
cacheFileRoot, if matchBitSet has no bit set? Will cacehFileRoot=null cause
issue in downstream logic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
