Thanks Jason. I am in the process of doing more unit testing, corner case testing etc before submitting for final review.
Thanks Subbu On Mon, Aug 22, 2016 at 9:51 AM, jaltekruse <g...@git.apache.org> wrote: > Github user jaltekruse commented on the issue: > > https://github.com/apache/drill/pull/518 > > After this was discussed at the Hangout a few weeks back, I had been > thinking about it more. > > My initial request was for warnings to be returned along with query > results. Some initial work was posted last fall to add warnings to the RPC > protocol, but unfortunately it was not brought to completion. These kinds > of warnings can be received by JDBC and ODBC sources and many tools show > them to users. > > https://github.com/apache/drill/pull/263 > > In the hangout we discussed that this changeset is currently logging > when part of a file is ignored. I don't believe that there is currently an > expectation that users should have to grep through a log file to find out > any additional information about the execution of a successful query, the > log files are there for admins to debug system issues. > > I still think it would be good to have a way to remove the need to > look through the log file to see if this behavior was used in a query, but > as there wasn't a lot of concern expressed by others when we discussed it, > I'm changing my vote to a +0. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
