Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403990
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -141,25 +141,41 @@ public void validate(final OptionValue v, final
OptionManager manager) {
public static class BooleanValidator extends TypeValidator {
public BooleanValidator(String name, boolean def) {
- super(name, Kind.BOOLEAN,
OptionValue.createBoolean(OptionType.SYSTEM, name, def));
+ this(name, def, false);
+ }
+
+ public BooleanValidator(String name, boolean def, boolean
isAdminOption) {
+ super(name, Kind.BOOLEAN,
OptionValue.createBoolean(OptionType.SYSTEM, name, def), isAdminOption);
}
}
public static class StringValidator extends TypeValidator {
public StringValidator(String name, String def) {
- super(name, Kind.STRING, OptionValue.createString(OptionType.SYSTEM,
name, def));
+ this(name, def, false);
+ }
+
+ public StringValidator(String name, String def, boolean isAdminOption)
{
--- End diff --
See above comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
