Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/585#discussion_r79096107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -592,11 +592,14 @@ public BatchGroup
mergeAndSpill(LinkedList<BatchGroup> batchGroups) throws Schem
}
injector.injectChecked(context.getExecutionControls(),
INTERRUPTION_WHILE_SPILLING, IOException.class);
newGroup.closeOutputStream();
- } catch (Exception e) {
+ } catch (Throwable e) {
// we only need to cleanup newGroup if spill failed
- AutoCloseables.close(e, newGroup);
+ try {
+ AutoCloseables.close(e, newGroup);
+ } catch (Throwable t) { /* close() may hit the same IO issue; just
ignore */ }
--- End diff --
It looks like close(Throwable t, AutoCloseable) suppresses the exception;
did you get an exception during testing ? Otherwise, you could remove this
second try-catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
