Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r80539844
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -120,9 +129,9 @@ public FunctionImplementationRegistry(DrillConfig
config, ScanResult classpathSc
* Register functions in given operator table.
* @param operatorTable
*/
- public void register(DrillOperatorTable operatorTable) {
+ public void register(DrillOperatorTable operatorTable, AtomicLong
version) {
--- End diff --
Perhaps describe the semantics (purpose) of the atomic long. Is this for
function versioning? If so, perhaps add a description of how this works to the
Javadoc comment for this class so that the reader understands what's happening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
