Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/573#discussion_r82305362
--- Diff: exec/java-exec/src/main/codegen/templates/TypeHelper.java ---
@@ -68,8 +68,23 @@ public static JType getHolderType(JCodeModel model,
MinorType type, DataMode mod
case UNION:
return model._ref(UnionHolder.class);
case MAP:
+ switch (mode) {
+ case REQUIRED:
--- End diff --
Perhaps combine the case statements to avoid repeated code:
case REQUIRED:
case OPTIONAL:
return model...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
