Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/611#discussion_r84970035
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
---
@@ -148,7 +185,8 @@ public boolean determineSize(long
recordsReadInCurrentPass, Integer lengthVarFie
return true;
}
- lengthVarFieldsInCurrentRecord += dataTypeLengthInBits;
+ // Never used in this code path. Hard to remove because the method is
overidden by subclasses
+ lengthVarFieldsInCurrentRecord = -1;
--- End diff --
why make this -1 even if not used ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
