Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r85241100
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
@@ -760,6 +765,24 @@ public void abort(Executor executor) throws
SQLException {
}
}
+ @Override
+ public boolean useAnsiQuotedIdentifiers() throws SQLException {
+ boolean systemOption = false;
+ Boolean sessionOption = null;
+ String sql = String.format("select type, bool_val from sys.options
where name = '%s'",
+ PlannerSettings.ANSI_QUOTES_KEY);
+ ResultSet rs = executeSql(sql);
--- End diff --
the statement is not closed, same for the result set, so resources are
leaked.
Also, there's an ongoing effort to remove hand-made requests to query
metadata and replace those by rpc calls. Shouldn't we introduce a new RPC call
to query session state instead? (it also makes things easier for the C++
connector)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
