Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/635#discussion_r85625856
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
@@ -493,4 +496,81 @@ public void withNullEqualAdditionFilter() throws
Exception {
.go();
}
+ @Test
+ public void withMixedEqualAndIsNotDistinctHashJoin() throws Exception {
--- End diff --
Could you add a test with the predicate of type:
t1.key = t2.key AND ((t1.data=t2.data) OR (t1.data IS NULL AND t2.data
IS NULL))
where the right side of the AND gets converted to IS NOT DISTINCT FROM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
