Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r85984205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -59,12 +59,13 @@
private final ListVectorOutput listOutput;
private final boolean extended = true;
private final boolean readNumbersAsDouble;
+ private List<String> path = Lists.newArrayList();
/**
* Collection for tracking nullable fields during reading
* and storing them for creating default typed vectors
*/
- private final Set<String> nullableFields = Sets.newLinkedHashSet();
+ private final Set<List<String>> nullableFields =
Sets.newLinkedHashSet();
--- End diff --
Do you mean the iterating on line 163 needs the order to be preserved? I
doubt it. Could you please double check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
