Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86057320
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -822,10 +838,103 @@ private void getFiles(String path, List<FileStatus>
fileStatuses) throws IOExcep
}
}
+ /*
+ * Figure out the best node to scan each of the rowGroups and update the
preferredEndpoint.
+ * Based on this, update the total work units assigned to the endpoint
in the endpointAffinity.
+ */
+ private void computeRowGroupAssignment() {
+ Map<DrillbitEndpoint, Integer> numEndpointAssignments =
Maps.newHashMap();
+ Map<DrillbitEndpoint, Long> numAssignedBytes = Maps.newHashMap();
+
+ // Do this for 2 iterations to adjust node assignments after first
iteration.
+ int numIterartions = 2;
+
+ while (numIterartions-- > 0) {
+
+ for (RowGroupInfo rowGroupInfo : rowGroupInfos) {
+ EndpointByteMap endpointByteMap = rowGroupInfo.getByteMap();
+
+ // This can be empty for local file system or if drilbit is not
running
+ // on hosts which have data.
+ if (endpointByteMap.isEmpty()) {
+ continue;
+ }
+
+ // Get the list of endpoints which have maximum (equal) data.
+ List<DrillbitEndpoint> topEndpoints =
endpointByteMap.getTopEndpoints();
--- End diff --
It took me a while to understand the below algorithm just by reading code.
It will be helpful if we can name the variables better here and add some
comment explaining different sections. Like changing as below might help:
1) "topEndPoints" to "maxRGDataEndPoints",
2) "minBytes" to "assignedBytesOnPickedNode"
3) "numBytes" to "assignedBytesOnCurrEndpoint"
4) "endpoint" to "currEndpoint"
As per my understanding line 864 to 892 represents one section which has
the below logic:
1) For each row group assign a drillbit from topEndPoints list such that
the chosen one is least loaded in terms of workunits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
