Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/560#discussion_r86104090
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
 ---
    @@ -378,8 +388,14 @@ public ValueHolder 
visitDoubleConstant(ValueExpressions.DoubleExpression dExpr,
         }
     
         @Override
    -    public ValueHolder 
visitQuotedStringConstant(ValueExpressions.QuotedString e, Integer value) 
throws RuntimeException {
    -      return 
ValueHolderHelper.getVarCharHolder(getManagedBufferIfAvailable(), e.value);
    +    public ValueHolder visitQuotedStringConstant(final 
ValueExpressions.QuotedString e, Integer value) throws RuntimeException {
    +      return getConstantValueHolder(e.value, new Function<DrillBuf, 
ValueHolder>() {
    --- End diff --
    
    My fault, you are totally right. Now cache stores holders by type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to