Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/644#discussion_r86384226
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -927,15 +927,11 @@ public void setMax(Object max) {
@JsonProperty List<ParquetFileMetadata_v2> files;
@JsonProperty List<String> directories;
@JsonProperty String drillVersion;
- @JsonProperty boolean isDateCorrect;
+ @JsonProperty int writerVersion;
--- End diff --
This property is Jackson-serialized. How does Jackson handle older files
written without this version? According to this post
(http://stackoverflow.com/questions/8320993/jackson-what-happens-if-a-property-is-missing),
"Setter methods are only invoked for properties with explicit values." This
means that older files without the writerVersion set won't call the function to
deserialize the writer version, and the version will default to the newest
version. I suspect that either A) I'm misunderstanding what this code does, or
B) we have a backward-compatibility issue. Please explain which.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
