Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/611#discussion_r86394036
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
 ---
    @@ -207,6 +207,10 @@ public OperatorContext getOperatorContext() {
         return operatorContext;
       }
     
    +  public FragmentContext getFragmentContext() {
    --- End diff --
    
    Giving the Parquet reader visibility to the FragmentContext causes tight 
coupling between the reader and the fragment (and thus to the Drillbit.) Is 
there a way to keep the reader independent of the fragment context for easier 
unit testing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to