Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87098173
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
RpcException {
connect(null, props);
}
+ /**
+ * Function to populate the endpointList with information of all the
drillbits
+ * provided in the connection string by client
+ * @param endpointList - ArrayList of DrillbitEndpoints
+ * @param drillbits - One or more drillbit ip[:port] provided in
connection string
--- End diff --
One or more drillbit -> drillbits
(Javadoc practice is to use lower case in param comments. See:
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide)
Please copy detailed description from method body to here so it shows up in
Javadoc.
I one port allowed? Or, should the user specify all three? If only one,
what port numbers are used for the other two? If this is documented elsewhere,
just point to that location.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
