Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/655#discussion_r88547748
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -132,7 +132,7 @@
<#list model.getOptionList() as option>
<tr>
<td>${option.getName()}</td>
- <td>${option.getValue()?c}</td>
+ <td>${option.getValue()?string}</td>
--- End diff --
According to the [documentation](), ?string works only for numbers and
formats them for "human display". ?c also works for numbers (and formats them
as "C" language constants.)
The challenge is that this template line works for all data types. So, the
suggestion of using toString( ) is good. But, since toString( ) may be used for
debugging, perhaps add a toDisplayString( ) that will format the value as we
want it to appear in the Web UI.
Another issue: are we sure that the value of option is always non-null at
this point?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
